Fokko commented on code in PR #4685:
URL: https://github.com/apache/iceberg/pull/4685#discussion_r871844026
##########
python/src/iceberg/schema.py:
##########
@@ -301,11 +336,10 @@ def _(obj: StructType, visitor: SchemaVisitor[T]) -> T:
@visit.register(ListType)
def _(obj: ListType, visitor: SchemaVisitor[T]) -> T:
"""Visit a ListType with a concrete SchemaVisitor"""
+
visitor.before_list_element(obj.element)
- try:
- result = visit(obj.element.type, visitor)
- finally:
Review Comment:
This was very confusing when debugging, and I don't think we should swallow
(at least not the broad Exception) those in silence. When visiting an element
caused an error, it would actually crash on something else because the state
was broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
