zinking commented on code in PR #4741:
URL: https://github.com/apache/iceberg/pull/4741#discussion_r872142932


##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -147,21 +185,69 @@ static Snapshot fromJson(FileIO io, JsonNode node) {
 
     Integer schemaId = JsonUtil.getIntOrNull(SCHEMA_ID, node);
 
+    List<StatisticsFile> statistics = null;

Review Comment:
   not sure how this project deals with null, how about init this to empty 
collection and void null checking as possible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to