kbendick commented on code in PR #4627:
URL: https://github.com/apache/iceberg/pull/4627#discussion_r872586522
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##########
@@ -112,11 +116,14 @@ public ParquetValueReader<RowData>
struct(Types.StructType expected, GroupType s
List<ParquetValueReader<?>> reorderedFields =
Lists.newArrayListWithExpectedSize(
expectedFields.size());
List<Type> types =
Lists.newArrayListWithExpectedSize(expectedFields.size());
+ // Inferring MaxDefinitionLevel from parent field
+ int inferredMaxDefinitionLevel =
type.getMaxDefinitionLevel(currentPath());
Review Comment:
Nit: Now that we're putting the field depth into the map
`maxDefinitionLevelsById`, and we have the same check for
`idToConstant.containsKey(id)`, do we need to have this fallback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
