aokolnychyi opened a new pull request, #4766:
URL: https://github.com/apache/iceberg/pull/4766

   This PR renames recently added and unreleased snapshot summary properties 
for equality and position delete files to match other recent public 
constants/methods.
   
   Specifically, all other snapshot properties use full words for `equality` 
and `position`.
   
   ```
   // SnapshotSummary
   public static final String ADDED_POS_DELETES_PROP = "added-position-deletes";
   public static final String REMOVED_POS_DELETES_PROP = 
"removed-position-deletes";
   public static final String TOTAL_POS_DELETES_PROP = "total-position-deletes";
   public static final String ADDED_EQ_DELETES_PROP = "added-equality-deletes";
   
   // ConvertEqualityDeleteFiles
   int convertedEqualityDeleteFilesCount();
   int addedPositionDeleteFilesCount();
   
   // FileWriterFactory
   EqualityDeleteWriter<T> newEqualityDeleteWriter(...);
   PositionDeleteWriter<T> newPositionDeleteWriter(...);
   
   etc
   ```
   
   Since the new snapshot summary properties haven't been released yet and were 
added recently, I'd consider renaming them for consistency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to