kbendick commented on PR #4638: URL: https://github.com/apache/iceberg/pull/4638#issuecomment-1126793562
> Thanks, @kbendick! This is great to have. I merged this. Do we expect builds to start failing now if there are binary breaking changes? Yes. In fact, builds might start failing now (the changes to gradle check were prossibly not run in this PR’s status checks). If you run `./gradlew check` it will run the api binary compatibility and then we can add justifications. The whole thing will tell us how. I’ll hop on my computer and open a PR or if you make one then I’ll review it. Then from there it will be required. @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
