nastra commented on code in PR #4786:
URL: https://github.com/apache/iceberg/pull/4786#discussion_r873601111
##########
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -103,5 +103,10 @@ protected class RowDataDeltaWriter extends
BaseEqualityDeltaWriter {
protected StructLike asStructLike(RowData data) {
return wrapper.wrap(data);
}
+
+ @Override
+ protected StructLike asStructLikeKey(RowData data) {
+ return wrapper.wrap(data);
Review Comment:
@kbendick should this throw an exception like in
https://github.com/apache/iceberg/blob/910f2712c7b731181c4a72fb6b8c66addeb76dd9/flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java#L109
or does it even matter what we return here for Flink 1.12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
