szehon-ho commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r874057523
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -227,6 +237,39 @@ public void close() {
}
}
+ private static class PositionStreamDeleteMarker<T> extends
PositionStreamDeleteFilter<T> {
+ private final Consumer<T> markDeleted;
+
+ private PositionStreamDeleteMarker(CloseableIterable<T> rows, Function<T,
Long> extractPos,
+ CloseableIterable<Long>
deletePositions, Consumer<T> markDeleted) {
+ super(rows, extractPos, deletePositions);
+ this.markDeleted = markDeleted;
+ }
+
+ @Override
+ protected PositionFilterIterator
createPosDeleteIterator(CloseableIterator<T> items,
+
CloseableIterator<Long> deletePosIterator) {
+ return new PositionDeleteMarkerIterator(items, deletePosIterator);
+ }
+
+ private class PositionDeleteMarkerIterator extends PositionFilterIterator {
Review Comment:
Just noticed this is same comment as @stevenzwu , can just continue
discussion there.
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -63,13 +65,23 @@ public static <T> CloseableIterable<T>
filter(CloseableIterable<T> rows, Functio
return equalityFilter.filter(rows);
}
- public static <T> CloseableIterable<T> filter(CloseableIterable<T> rows,
Function<T, Long> rowToPosition,
- PositionDeleteIndex deleteSet)
{
- if (deleteSet.isEmpty()) {
- return rows;
- }
+ public static <T> CloseableIterable<T> markDeleted(CloseableIterable<T>
rows, Predicate<T> isDeleted,
Review Comment:
Sorry you are right, we have to return even non-deleted rows here, never
mind about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
