bryanck commented on code in PR #4771:
URL: https://github.com/apache/iceberg/pull/4771#discussion_r874120167
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1435,12 +1463,102 @@ components:
additionalProperties:
type: string
+ OAuthTokenRequest:
+ description:
+ OAuth2 client credentials or token exchange request
+
+
+ See -
+
+ - Client credentials flow -
https://datatracker.ietf.org/doc/html/rfc6749#section-4.4
+
+ - Token exchange flow - https://datatracker.ietf.org/doc/html/rfc8693
+ type: object
+ required:
+ - grant_type
+ properties:
+ grant_type:
+ type: string
+ enum:
+ - client_credentials
+ - urn:ietf:params:oauth:grant-type:token-exchange
+ client_id:
+ type: string
+ description:
+ Client ID for client credentials flow.
+
+
+ This can be sent in the request body, but OAuth2 recomments
sending it in
+ a Basic Authorization header.
+ client_secret:
+ type: string
+ description:
+ Client secret for client credentials flow.
+
+
+ This can be sent in the request body, but OAuth2 recomments
sending it in
+ a Basic Authorization header.
+ subject_token:
+ type: string
+ description: Subject token for token exchange request
+ subject_token_type:
+ type: string
+ description: Subject token type for token exchange request
+ scope:
+ type: string
#############################
# Reusable Response Objects #
#############################
responses:
+ OAuthTokenResponse:
Review Comment:
Yeah, that's what I meant, that the required fields for the grant token
response are only `access_token` and `token_type` in the spec. For token
exchange, `issued_token_type` is also required. For token exchange, the
`token_type` is referring to the HTTP Authorization token type, e.g. most of
the time set to `bearer`. Also, `expires_in` is recommended but optional (for
both).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
