vamen commented on code in PR #4099:
URL: https://github.com/apache/iceberg/pull/4099#discussion_r874733000
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -431,6 +433,34 @@ protected boolean isValidIdentifier(TableIdentifier
tableIdentifier) {
IcebergToGlueConverter.isValidTableName(tableIdentifier.name());
}
+ @Override
+ public org.apache.iceberg.Table registerTable(TableIdentifier identifier,
String metadataFileLocation) {
+ Preconditions.checkArgument(isValidIdentifier(identifier),
Review Comment:
what was the initial idea of registerTable method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
