kbendick commented on code in PR #4011: URL: https://github.com/apache/iceberg/pull/4011#discussion_r875089102
########## aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java: ########## @@ -92,7 +93,7 @@ public class GlueCatalog extends BaseMetastoreCatalog private FileIO fileIO; private LockManager lockManager; private CloseableGroup closeableGroup; - private Map<String, String> catalogProperties; + private Map<String, String> catalogProperties = Collections.emptyMap(); Review Comment: Nit: Unless we _need_ null values in the map, we almost always prefer shaded-guava's `ImmutableMap.of()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
