kbendick commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r875287975
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -234,6 +290,57 @@ private static void
writeAddSortOrder(MetadataUpdate.AddSortOrder update, JsonGe
SortOrderParser.toJson(update.sortOrder(), gen);
}
+ private static void
writeSetDefaultSortOrder(MetadataUpdate.SetDefaultSortOrder update,
JsonGenerator gen)
+ throws IOException {
+ gen.writeNumberField(SORT_ORDER_ID, update.sortOrderId());
+ }
+
+ private static void writeAddSnapshot(MetadataUpdate.AddSnapshot update,
JsonGenerator gen) throws IOException {
+ gen.writeFieldName(SNAPSHOT);
+ SnapshotParser.toJson(update.snapshot(), gen);
+ }
+
+ // TODO - Reconcile the spec's set-based removal with the current class
implementation that only handles one value.
+ private static void writeRemoveSnapshots(MetadataUpdate.RemoveSnapshot
update, JsonGenerator gen) throws IOException {
Review Comment:
Same note about multiple snapshots being allowed in the code. Although for
now this should be fine.
I'll hold off on editing this until more input re: following up
`RemoveSnapshots` in another PR or simply only supporting one value is
determined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
