rdblue commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r875346828
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -271,5 +378,51 @@ private static MetadataUpdate readAddSortOrder(JsonNode
node) {
UnboundSortOrder sortOrder = SortOrderParser.fromJson(sortOrderNode);
return new MetadataUpdate.AddSortOrder(sortOrder);
}
+
+ private static MetadataUpdate readSetDefaultSortOrder(JsonNode node) {
+ int sortOrderId = JsonUtil.getInt(SORT_ORDER_ID, node);
+ return new MetadataUpdate.SetDefaultSortOrder(sortOrderId);
+ }
+
+ private static MetadataUpdate readAddSnapshot(JsonNode node) {
+ Snapshot snapshot = SnapshotParser.fromJson(null, node);
Review Comment:
Looks like this is slightly wrong. The node passed in is the update, but it
should pass `node.get(SNAPSHOT)` here instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
