chenjunjiedada commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r875397380
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -290,8 +295,6 @@ private static Schema fileProjection(Schema tableSchema,
Schema requestedSchema,
requiredIds.addAll(eqDelete.equalityFieldIds());
}
- requiredIds.add(MetadataColumns.IS_DELETED.fieldId());
Review Comment:
We already project an extra position column, right? It depends on whether
the projected column is useful. The projected `_delete` column can be used for
converting delete as I wrote if I recall. The CDC changes may also need it for
joining, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
