rajarshisarkar commented on PR #4011: URL: https://github.com/apache/iceberg/pull/4011#issuecomment-1129840683
> Do we have any worries about catalog defaults accidentally affecting a table that a user didn't intend it to? I know some properties have been called out as possibly better suited as per-job definitions (like write.upsert.enabled for Flink Iceberg Sink). > > This might be a non-concern, particularly if it's well documented, but we might want to at least log the property keys for which we pulled a default value from the catalog level? > > Would love to hear from others if they have any similar concerns, and if there's any proposed solution. @kbendick I don't think we need to worry as only the catalog properties with a certain prefix are considered, +1 for logging. https://github.com/apache/iceberg/blob/13b1a737da45b13beffb2c7b112def188e4e1c10/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L226-L233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
