Fokko opened a new pull request, #4811: URL: https://github.com/apache/iceberg/pull/4811
I would like to suggest moving away from tox into pre-commit. A couple of things in this PR: - Moving away from tox to pre-commit. [Pre-commit](https://pre-commit.com/) is a very popular tool for running linting tools for Python. - I don't think tox isn't very effective (anymore) since most people use Docker or their system Python. - Pre-commit is very easy to understand and manage - Pin the versions of all the linters (instead of installing the latest and greatest before). Updating using pre-commit is very easy: `pre-commit autoupdate`. - Removed the duplicate test_raise_on_checking_if_local_file_exists_no_permission test: https://github.com/apache/iceberg/search?q=test_raise_on_checking_if_local_file_exists_no_permission This was caught now we also run the linters on the test codebase. - Updated the docs on how to run linting and testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
