kbendick commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r876246180
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -233,25 +233,25 @@ public void applyTo(TableMetadata.Builder
metadataBuilder) {
}
class SetSnapshotRef implements MetadataUpdate {
- private final String name;
+ private final String refName;
Review Comment:
Given we updated the spec to use `ref-name`, I also changed the field name
and the method name.
I can do this in a separate PR (as well as update the spec in that same PR)
or I can leave the class's code as is for now. WDYT? Changing it here does
admittedly make the PR's scope somewhat broad for what it touches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
