szehon-ho commented on code in PR #4662:
URL: https://github.com/apache/iceberg/pull/4662#discussion_r877270103
##########
core/src/test/java/org/apache/iceberg/TestDataTableScan.java:
##########
@@ -130,4 +132,63 @@ public void testTableScanWithPlanExecutor() {
Assert.assertEquals(2, Iterables.size(scan.planFiles()));
Assert.assertTrue("Thread should be created in provided pool",
planThreadsIndex.get() > 0);
}
+
+ @Test
+ public void testReaddingPartitionField() throws Exception {
+ Assume.assumeTrue(formatVersion == 2);
Review Comment:
I see, yea that makes sense, it would be great to add coverage for V1 in
another pr.
Side note, last time I end up doing if v1/v2 based on the review feedback :
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java#L627.
But yea its not elegant, I also wrote two tests before based on another
review feedback:
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestMetadataTableFilters.java#L285.
I am not sure which is cleaner , will unify this at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
