wypoon commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r877678381
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -40,7 +46,11 @@ public void delete(long posStart, long posEnd) {
@Override
public boolean isDeleted(long position) {
- return roaring64Bitmap.contains(position);
+ boolean posIsDeleted = roaring64Bitmap.contains(position);
+ if (counter != null && posIsDeleted) {
+ counter.increment();
+ }
Review Comment:
Since it has been almost 4 weeks since I touched this (it seems that's how
long the last update has gone unreviewed), I had forgotten the details of what
I had investigated and had done. I went through the code paths again, and I see
now that there is just one place where `PositionDeleteIndex#delete()` is called
and where I need to track the delete count in the `PositionDeleteIndex`. So
your suggestion is very feasible and not messy as I feared!
Thank you for the suggestion. I'll update the PR tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
