rdblue commented on code in PR #4246:
URL: https://github.com/apache/iceberg/pull/4246#discussion_r878411542
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -48,7 +48,7 @@ private IcebergTableSink(IcebergTableSink toCopy) {
this.readableConfig = toCopy.readableConfig;
}
- public IcebergTableSink(TableLoader tableLoader, TableSchema tableSchema,
ReadableConfig readableConfig) {
+ public IcebergTableSink(TableLoader tableLoader, ResolvedSchema tableSchema,
ReadableConfig readableConfig) {
Review Comment:
What does it mean for the sink to accept a resolved schema? This schema must
match the table schema exactly, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
