hililiwei commented on code in PR #4246:
URL: https://github.com/apache/iceberg/pull/4246#discussion_r878647007
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -48,7 +48,7 @@ private IcebergTableSink(IcebergTableSink toCopy) {
this.readableConfig = toCopy.readableConfig;
}
- public IcebergTableSink(TableLoader tableLoader, TableSchema tableSchema,
ReadableConfig readableConfig) {
+ public IcebergTableSink(TableLoader tableLoader, ResolvedSchema tableSchema,
ReadableConfig readableConfig) {
Review Comment:
yes, it's generated from content. In `DynamicTableSink`, tasks can get the
Resolved Schema correctly. It belongs to the Table API and is not a high-level
API for developers .
https://github.com/apache/iceberg/blob/16653921fe1d9689b8f6ed6ab44683d4379e52cd/flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java#L101-L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
