samredai commented on code in PR #4815:
URL: https://github.com/apache/iceberg/pull/4815#discussion_r878986833
##########
python/src/iceberg/expressions/base.py:
##########
@@ -346,3 +346,116 @@ def bind(self, schema: Schema, case_sensitive: bool) ->
BoundReference:
raise ValueError(f"Cannot find field '{self.name}' in schema:
{schema}")
return BoundReference(field=field,
accessor=schema.accessor_for_field(field.field_id))
+
+
+class BooleanExpressionVisitor(ABC):
Review Comment:
I see, updated to `BooleanExpressionVisitor(Generic[T], ABC)` 👍
##########
python/src/iceberg/expressions/base.py:
##########
@@ -346,3 +346,116 @@ def bind(self, schema: Schema, case_sensitive: bool) ->
BoundReference:
raise ValueError(f"Cannot find field '{self.name}' in schema:
{schema}")
return BoundReference(field=field,
accessor=schema.accessor_for_field(field.field_id))
+
+
+class BooleanExpressionVisitor(ABC):
+ @abstractmethod
+ def visit_always_true(self) -> BooleanExpression:
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
