singhpk234 opened a new pull request, #4836:
URL: https://github.com/apache/iceberg/pull/4836

   ### About the Change
   
   This is an extension of the work done in 
https://github.com/apache/iceberg/pull/4687
   
   Spark actions also manipulate the table obj, apart of SparkWrite and hence, 
the handling of CommitStateUnknown exception when encountered, should not 
delete the added files.
   
   While actions such as RewriteDatafiles have this handling :
   
https://github.com/apache/iceberg/blob/566b2fe3f31f4a53f5a26aca1c4239085de4a994/core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java#L108-L120
   
   found this missing in RewriteManifestSparkAction, hence added the same. 
   
   ----- 
   
   ### Testing done
   
   Added a UT to demonstrate the E2E , without the change the UT fails with 
File Not found exception thus leading to table corruption 
   
   ---- 
   
   cc @RussellSpitzer, @stevenzwu @flyrain @aokolnychyi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to