CodingCat commented on PR #4795:
URL: https://github.com/apache/iceberg/pull/4795#issuecomment-1135168675

   > Actually, I think there's an existing way that the thread ID could be 
exposed in the snapshot summary. Look into the 
`SnapshotSummary.EXTRA_METADATA_PREFIX`. Basically, in the spark `options` used 
on write, you'd add `snapshot-property.${desired_summary_key}` = 
`${desired_value_for_key}`. And then on write, in the snapshot summary, 
`desired_summary_key = desired_value_for_key` will be written.
   > 
   > See here where the options are added:
   > 
   > 
https://github.com/apache/iceberg/blob/feeb94b255b705382282e04fbeb1efdc3210d6cc/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java#L168-L175
   > 
   > And here where the key is defined:
   > 
   > 
https://github.com/apache/iceberg/blob/feeb94b255b705382282e04fbeb1efdc3210d6cc/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L60
   
   well, the reason I didn't go into this obviously easier path is that we 
there is no way for me to add this snapshot tag when we do DELETE and UPSERT 
(or I didn't find it?) 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to