jackye1995 commented on code in PR #4428:
URL: https://github.com/apache/iceberg/pull/4428#discussion_r881254521


##########
api/src/main/java/org/apache/iceberg/TableScan.java:
##########
@@ -49,6 +49,24 @@
    */
   TableScan useSnapshot(long snapshotId);
 
+  /**
+   * Create a new {@link TableScan} from this scan's configuration that will 
use the given branch
+   *
+   * @param branch the branch to scan from
+   * @return a new scan based on this with the given branch
+   * @throws IllegalArgumentException if the branch cannot be found
+   */
+  TableScan branch(String branch);

Review Comment:
   Actually I think there is a need to distinguish `useBranch` and `useTag`, 
because `useBranch` can be used in combiantion with `asOfTime` to perform time 
travel against a specific branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to