XN137 commented on PR #4851: URL: https://github.com/apache/iceberg/pull/4851#issuecomment-1136776132
thanks for the reviews. > I would keep in mind that these changes are not the tests that got run as part of CI in this PR (github uses the current definition in master). is this really true? when i check the workflow runs on this PR i see all the latest action versions being used, for example:  https://github.com/apache/iceberg/runs/6568370241?check_suite_focus=true Afaik only the labeler workflow isnt being exercised as part of this PR (so there is a very low risk of breaking it on merge, but I would be checking that right after). > Question about explicitly setting the ubuntu version: Why not just move to 22 now? Just to keep the changes somewhat separated? the image is still in beta, see https://github.com/actions/virtual-environments/issues/5490 while we could try upgrading, we should do so in a separate PR imo. as stated earlier the idea to avoid using "ubuntu-latest" is to have full control on when that upgrade happens (to make sure CI remains stable). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
