kbendick commented on code in PR #4865:
URL: https://github.com/apache/iceberg/pull/4865#discussion_r882341229
##########
docs/flink/flink-getting-started.md:
##########
@@ -547,6 +547,64 @@ RewriteDataFilesActionResult result =
Actions.forTable(table)
For more doc about options of the rewrite files action, please see
[RewriteDataFilesAction](../../../javadoc/{{% icebergVersion
%}}/org/apache/iceberg/flink/actions/RewriteDataFilesAction.html)
+## Type compatibility
+
+Flink and Iceberg support different set of types. Iceberg does the type
conversion automatically, but not for all combinations,
Review Comment:
Additionally, I would say they support “different” types. There are logic
types (eg UUID), physical types (eg String or VARCHAR), and then what’s
ultimately stored within the respective file types and how.
I’d focus on covering the first two here (logical and physical). And making
notes of any peculiarities that are different within the matrix - for example,
I believe that timestamp precision and what is and us not possible to store
_might_ be worth calling more attention to in the notes section of the matrix.
For this sentence, I’d say something more along the lines of “Iceberg’s type
system is mapped to Flink’s type system. This type conversion can be done by
Iceberg automatically, though the following cases need to be considered. See
the notes section below for compatibility concerns and how to overcome them”.
Then I’d make a small section listing the combinations that don’t work or
general discussion of the mounts of concern. As we’re migrating the docs
somewhat to a new structure, so I think that would really help (even if you
can’t list all cases etc)
Just a suggestion / jumping off point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
