waltczhang commented on code in PR #4154:
URL: https://github.com/apache/iceberg/pull/4154#discussion_r882411827
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java:
##########
@@ -130,8 +131,7 @@ public Write build() {
Preconditions.checkArgument(handleTimestampWithoutZone ||
!SparkUtil.hasTimestampWithoutZone(table.schema()),
SparkUtil.TIMESTAMP_WITHOUT_TIMEZONE_ERROR);
- Schema writeSchema = SparkSchemaUtil.convert(table.schema(), dsSchema);
- TypeUtil.validateWriteSchema(table.schema(), writeSchema,
writeConf.checkNullability(), writeConf.checkOrdering());
Review Comment:
@rdblue Thanks for your reply, I agree you. Transaction is not important, If
try to achieve transaction during SparkWrite, there are some problems in sql,
for example when I execute the sql"create table as select * from xxx" , it will
throw "Cannot create a transaction within a transaction" question. I think it
is a disadvantage in sql to achieve transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
