samredai commented on code in PR #4717:
URL: https://github.com/apache/iceberg/pull/4717#discussion_r882941190
##########
python/src/iceberg/table/partitioning.py:
##########
@@ -14,8 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from typing import Dict, Iterable, List, Tuple
+
+from iceberg.schema import Schema
from iceberg.transforms import Transform
+_PARTITION_DATA_ID_START: int = 1000
+
class PartitionField:
Review Comment:
I really like this idea of wrapping the classes generated from the OpenAPI
spec. The class naming here might be tricky. Module namespacing allows us to
re-use the same name if we want, something like:
```py
from iceberg.openapi import rest_catalog
class PartitionField(rest_catalog.PartitionField):
...
```
We shouldn't expect users to import from the openapi module directly so we
shouldn't need to worry about naming conflicts, right? Maybe we should name it
`_openapi` just to be super clear about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
