aokolnychyi commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r883034064
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java:
##########
@@ -195,5 +195,10 @@ protected StructLike asStructLike(InternalRow row) {
protected InputFile getInputFile(String location) {
return RowDataReader.this.getInputFile(location);
}
+
+ @Override
+ protected void markRowDeleted(InternalRow row) {
+ row.setBoolean(columnIsDeletedPosition(), true);
Review Comment:
What happens if this is not called? Do we just assume the default value
persisted is false? This seems a bit unreliable and may not be true in other
engines or even other row implementations.
Would it make make sense to pass the boolean value in this method and set it
explicitly? Then we won't need that if block too, we just compute the value and
set it.
```
protected void setIsDeletedColumn(InternalRow row, boolean isDeleted) {
row.setBoolean(isDeletedColumnPosition, isDeleted);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
