flyrain commented on code in PR #4683:
URL: https://github.com/apache/iceberg/pull/4683#discussion_r883058619
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java:
##########
@@ -195,5 +195,10 @@ protected StructLike asStructLike(InternalRow row) {
protected InputFile getInputFile(String location) {
return RowDataReader.this.getInputFile(location);
}
+
+ @Override
+ protected void markRowDeleted(InternalRow row) {
+ row.setBoolean(columnIsDeletedPosition(), true);
Review Comment:
Yes. That's the assumption. Agreed that we'd better not have that
assumption. There will be a bit more expensive since we need to set every row
now. I'd guess the perf impact is minor though. Will make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
