rdblue commented on code in PR #4706:
URL: https://github.com/apache/iceberg/pull/4706#discussion_r883922107
##########
python/tests/conftest.py:
##########
@@ -112,3 +113,8 @@ def table_schema_nested():
@pytest.fixture(scope="session", autouse=True)
def foo_struct():
return FooStruct()
+
+
[email protected]
+def catalog() -> InMemoryCatalog:
+ return InMemoryCatalog("test.in.memory.catalog", {"test.key":
"test.value"})
Review Comment:
`test.key` isn't used anywhere, nor is `test.in.memory.catalog`. Can you add
tests for properties and name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
