stevenzwu commented on PR #4886: URL: https://github.com/apache/iceberg/pull/4886#issuecomment-1140044325
@aokolnychyi For the [boolean flag comment](https://github.com/apache/iceberg/pull/4744#discussion_r883936190), do you think a builder class for `IncrementalScanEvent` would be better? For the [helper methods comment](https://github.com/apache/iceberg/pull/4744#discussion_r883943057), I feel we are adding a bunch of methods without making the code much simpler. For the [schema evolution comment](https://github.com/apache/iceberg/pull/4744#discussion_r883912168), I think it is outside the scope of streaming source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
