Fokko opened a new pull request, #4891:
URL: https://github.com/apache/iceberg/pull/4891
For Python, when we generate classes it is required
to have the non-default variables first:
This is not allowed:
```python
class ListType(IcebergType, rest_catalog.ListType):
def __init__(
cls,
element_id: int,
element_required: bool = True,
type: IcebergType
):
```
It would be nice to have the type first (which is also more important),
and then required/optional. Of course, we can just adjust this in the
Python init method, but would be nice to have this order the same in the
open-api spec as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
