rdblue commented on code in PR #4894:
URL: https://github.com/apache/iceberg/pull/4894#discussion_r884321221
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java:
##########
@@ -37,8 +37,8 @@ private OAuth2Properties() {
* Interval in milliseconds to wait before attempting to exchange the
configured catalog Bearer token.
* By default, token exchange will be attempted after 1 hour.
*/
- public static final String EXCHANGE_TOKEN_MS = "exchange-token-in-ms";
- public static final long EXCHANGE_TOKEN_MS_DEFAULT = 3_600_000; // 1 hour
+ public static final String TOKEN_EXPIRES_IN_MS = "token-expires-in-ms";
Review Comment:
All other durations in Iceberg config use milliseconds, so I did this for
consistency. I agree it doesn't help much, but I think consistency is important
so people don't always need to look up the expected unit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
