amogh-jahagirdar commented on code in PR #4428:
URL: https://github.com/apache/iceberg/pull/4428#discussion_r884400092
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -297,4 +297,18 @@ default AppendFiles newFastAppend() {
* Returns a {@link LocationProvider} to provide locations for new data
files.
*/
LocationProvider locationProvider();
+
+ /**
+ * Returns the current refs for the table
+ *
+ * @return the current refs for the table
+ */
+ Map<String, SnapshotRef> refs();
Review Comment:
Actually, one thing I forgot was for SerializableTable, we'll need to pass
the refs through
https://github.com/apache/iceberg/pull/4428/files#diff-46dafb425240806166ccc8f27a6c301781c5082bf1a187291cc92c2a8f17a588R85
so we'll need Map<String, SnapshotRef> refs() to implement the contract of
snapshot(String name) in SerializableTable.
So then we need both refs() and snapshot(String name).
I think can leave off the ref(String name) for now, until we know that
convenience method is really useful; I anticipate it will become useful mostly
just to avoid another level of indirection when looking up from the map, but we
can aim for just keeping the API changes minimal for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
