snazy commented on code in PR #4826:
URL: https://github.com/apache/iceberg/pull/4826#discussion_r885281837
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -157,19 +161,27 @@ public TableBuilder withProperty(String key, String
value) {
return this;
}
+ public TableMetadata newTableMetadata() {
Review Comment:
Should be `protected`
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -157,19 +161,27 @@ public TableBuilder withProperty(String key, String
value) {
return this;
}
+ public TableMetadata newTableMetadata() {
+ String baseLocation = location != null ? location :
defaultWarehouseLocation(identifier);
+ tableProperties.putAll(tableOverrideProperties());
+ return TableMetadata.newTableMetadata(schema, spec, sortOrder,
baseLocation, tableProperties);
+ }
+
+ public TableMetadata replacedTableMetadata(TableOperations ops) {
Review Comment:
Should be `protected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
