pvary commented on PR #4734: URL: https://github.com/apache/iceberg/pull/4734#issuecomment-1142287028
> > > Do we shade in the ORC Version? Just checking because this could potentially break folks who are using the older versions of ORC at runtime right? > > > > > > I think we do not shade things. We had to do that in Hive code to avoid clashing versions. We also struggle with Parquet and Avro. It might worth considering shading our own versions of file formats. But it is for another PR. > > We do shade parquet. If you open up a spark repl with the iceberg-spark-runtime it’s under `org.apache.iceberg.relocated.org.apache.parquet` I believe. If the others aren’t there (which I believe they are), we should look into adding them. Thanks for the pointer @kbendick. So the issue is solved for all the runtime jars (found the same code for Flink and Hive too). So it is just the direct users of the core jars who has to do that themselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
