rdblue commented on code in PR #4792:
URL: https://github.com/apache/iceberg/pull/4792#discussion_r886262199
##########
python/src/iceberg/io/base.py:
##########
@@ -41,10 +41,10 @@ class InputStream(Protocol): # pragma: no cover
implementation's `open(...)` method. These methods are a subset of
IOBase/RawIOBase.
"""
- def read(self, size: int) -> bytes:
+ def read(self, n: int = -1) -> bytes:
Review Comment:
Sound good. We may want to consider adding docs that at least point to the
canonical ones, but that's not something that should block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
