aokolnychyi commented on code in PR #4870: URL: https://github.com/apache/iceberg/pull/4870#discussion_r887276736
########## api/src/main/java/org/apache/iceberg/ChangelogScanTask.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +/** + * A changelog scan task. + */ +public interface ChangelogScanTask extends FileScanTask { Review Comment: I am debating whether we should extend `FileScanTask` or not. Some benefits of extending: - Our usage kind of fits the description: `A scan task over a range of a single file`. - We can reuse split logic and `CombinedScanTask`. - We can reuse the existing `planFiles` and `planTasks` methods. - We can reuse a lot of reader code that assumes we get some sort of `FileScanTask`. This is really useful as we can use `JoinedRow` in Spark to add extra metadata to an iterable of `InternalRows` we get back by reading regular tasks. ########## api/src/main/java/org/apache/iceberg/ChangelogScanTask.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +/** + * A changelog scan task. + */ +public interface ChangelogScanTask extends FileScanTask { Review Comment: I am debating whether we should extend `FileScanTask` or not. Some benefits of extending: - Our usage kind of fits the description: `A scan task over a range of a single file`. - We can reuse split logic and `CombinedScanTask`. - We can reuse the existing `planFiles` and `planTasks` methods. - We can reuse a lot of reader code that assumes we get some sort of `FileScanTask`. This is really useful as we can use `JoinedRow` in Spark to add extra metadata to an iterable of `InternalRow`s we get back by reading regular tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
