rajarshisarkar commented on code in PR #4941:
URL: https://github.com/apache/iceberg/pull/4941#discussion_r887782817
##########
core/src/test/java/org/apache/iceberg/actions/TestSortStrategy.java:
##########
@@ -86,9 +86,6 @@ private List<FileScanTask> tasksForSortOrder(int sortOrderId,
int... fileSizesMB
@Test
public void testInvalidSortOrder() {
- AssertHelpers.assertThrows("Should not allow an unsorted Sort order",
IllegalArgumentException.class,
- () ->
defaultSort().sortOrder(SortOrder.unsorted()).options(Collections.emptyMap()));
Review Comment:
This test fails now as the table has a partition spec:
```
[
1000: data_bucket: bucket[16](2)
]
```
Resulting in the overall Sort Order to be:
```
[
bucket[16](2) ASC NULLS FIRST
]
```
Hence, no scope of `IllegalArgumentException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
