CircArgs commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r889186710
##########
python/src/iceberg/expressions/base.py:
##########
@@ -137,6 +75,28 @@ def __invert__(self) -> "BooleanExpression":
...
+class BoundPredicate(ABC):
+ def __init__(self, left, right):
+ """A concrete predicate must have a `left` and `right`"""
+ self._left = left
+ self._right = right
+
+ @abstractmethod
+ def eval(self, struct: StructProtocol) -> bool:
Review Comment:
I got rid of all the eval methods
##########
python/src/iceberg/expressions/base.py:
##########
@@ -267,6 +226,68 @@ def __str__(self) -> str:
return "false"
+class UnboundIn(BooleanExpression, UnboundPredicate):
+ """IN operation expression"""
+
+ def __init__(self, left: "UnboundReference", right: List[Literal]): #
pylint: disable=super-init-not-called
+ self._left = left
+ self._right = right
+
+ @property
+ def left(self) -> "UnboundReference":
+ return self._left
+
+ @property
+ def right(self) -> List[Literal]:
+ return self._right
+
+ def __eq__(self, other) -> bool:
+ return id(self) == id(other) or (isinstance(other, UnboundIn) and
self.left == other.left and self.right == other.right)
+
+ def __invert__(self) -> Not:
+ return Not(self)
Review Comment:
now throws exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
