rdblue commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r889294462
##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -60,4 +60,9 @@
* @return this for method chaining
*/
ThisT scanManifestsWith(ExecutorService executorService);
+
+ /**
+ * Perform operations a particular branch
Review Comment:
This needs a `@param` to document branch. I think we also need to specify
behavior:
* What happens if the branch does not exist? I think we would create one
from the `main` branch.
* How does this change validation? What if the validation's from snapshot is
not an ancestor of the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
