kbendick commented on code in PR #4958:
URL: https://github.com/apache/iceberg/pull/4958#discussion_r889628755
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -369,6 +369,7 @@ public void close() throws IOException {
ScheduledExecutorService service = refreshExecutor;
this.refreshExecutor = null;
+ service.shutdown();
Review Comment:
Agreed. This is sufficient for now in my opinion. I also think the example
from the javadoc might be overkill (if anything the results will simply be
processed and not returned to anything by the server, which happens all the
time during shutdown etc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
