stevenzwu commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r889801693
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -134,15 +140,33 @@ public void snapshotState(FunctionSnapshotContext
context) throws Exception {
public void run(SourceContext<FlinkInputSplit> ctx) throws Exception {
this.sourceContext = ctx;
while (isRunning) {
+ LOG.debug("Start polling snapshots from snapshot id: {},
max-snapshots-per-monitor-interval: {}", lastSnapshotId,
+ scanContext.maxSnapshotsPerMonitorInterval());
+ long start = System.currentTimeMillis();
+ long startSnapshotId = lastSnapshotId;
synchronized (sourceContext.getCheckpointLock()) {
if (isRunning) {
monitorAndForwardSplits();
}
}
+ LOG.debug("Forwarded splits from {}(exclusive) to {}(inclusive), time
elapsed {}ms",
Review Comment:
yes. I missed `lastSnapshotId` was updated by `monitorAndForwardSplits`. It
also means that the code is difficult to read. we are relying on the side
effect of the `monitorAndForwardSplits` method. It is more clear to avoid such
side effect. Plus it is better to measure the latency separately: planning vs
emitting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
