findepi commented on code in PR #4945:
URL: https://github.com/apache/iceberg/pull/4945#discussion_r890858934
##########
format/spec.md:
##########
@@ -513,6 +514,17 @@ Manifests for a snapshot are tracked by a manifest list.
Valid snapshots are stored as a list in table metadata. For serialization, see
Appendix C.
+Statistics files' metadata within `statistics` field is a struct with the
following fields:
+
+| Field name | Type |
Description
|
+|---------------------------------|------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| **`location`** | `string` |
Location of the statistics file. See [Puffin file format](../puffin).
|
+| **`file-size-in-bytes`** | `long` | Size
of the statistics file.
|
+| **`file-footer-size-in-bytes`** | `long` | Size
of the statistics file's footer. See [Puffin file format](../puffin) for footer
definition.
|
+| **`source-sequence-number`** | `long` | Table
sequence number at which the stats were calculated
|
+| **`statistics-fields-sets`** | `map<string, list<list<integer>>>` | A map
indicating which statistics are contained in the statistics file and on which
columns they were calculated. The map keys are statistics sketch names and map
values represent sets of columns, given by column ID. |
Review Comment:
> * There can be one object per field set rather than combining by blob name
changed
> * The objects are extensible and can carry more information,
good point about extensibility.
i pushed a new version which allows that, and also added properties field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
