hililiwei commented on PR #3998: URL: https://github.com/apache/iceberg/pull/3998#issuecomment-1149353678
> I think it is a good idea to be able to override some table properties in the runtime configuration. However, I'm -1 for the approach taken by this PR, which replaces the table properties with overridden properties. I think they should be kept separate so that it is clear what is happening. > > We have the same feature in Spark, but Spark defines more specific contextual properties to do the override. Here's a concrete example: it makes more sense to set `write-format` than to set `write.format.default` when configuring a write. What does it mean to set a "default" for the write? I read the implementation of Spark. It does make more sense than the current PR. I will modify it in the same way as Spark. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
