kbendick commented on code in PR #4989:
URL: https://github.com/apache/iceberg/pull/4989#discussion_r892708718
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -38,15 +38,25 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
+ if: github.event_name == 'pull_request'
+ with:
+ # fetch-depth of zero ensures that the tags are pulled in and we're
not in a detached HEAD state
+ # revapi depends on the tags, specifically the tag from git
describe, to find the relevant override
+ # in the .palantir/revapi.yml file
+ #
+ # See https://github.com/actions/checkout/issues/124
+ fetch-depth: 0
+ ref: ${{ github.event.pull_request.head.ref }}
Review Comment:
I pulled this from the most voted answer in the issue - which is hard to
find because it's got some links but several people confirmed it. And then I
checked it as well in my fork.
But I think you're right. It's hard to track down the actions@v2 docs and I
didn't want to be the first to upgrade, but I forgot that we already have
upgraded other actions to `checkout@v3`. It's a little harder for me to test
given I don't have the full permissions in this repository (or possibly just
don't know the correct workflow).
Let me try what you suggested in my fork really quickly as I do believe you
are right looking closer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
