jfz commented on code in PR #4760:
URL: https://github.com/apache/iceberg/pull/4760#discussion_r893731274


##########
api/src/main/java/org/apache/iceberg/io/LocationProvider.java:
##########
@@ -37,6 +38,17 @@ public interface LocationProvider extends Serializable {
    */
   String newDataLocation(String filename);
 
+  /**
+   * Return a fully-qualified data file location for the given filename and 
options.
+   *
+   * @param filename a file name
+   * @param options options for deciding the location
+   * @return a fully-qualified location URI for a data file
+   */
+  default String newDataLocation(String filename, Map<String, String> options) 
{

Review Comment:
   We can workaround this if this is not generic enough for OSS version, 
closing this PR, thanks for looking at this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to