[GitHub] [iceberg] rdblue commented on a diff in pull request #4943: Flink: add an option to set monitoring snapshot number

[GitBox]

rdblue commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r894945592


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -155,13 +178,21 @@ private void monitorAndForwardSplits() {
       if (lastSnapshotId == INIT_LAST_SNAPSHOT_ID) {
         newScanContext = scanContext.copyWithSnapshotId(snapshotId);
       } else {
+        snapshotId = maxReachableSnapshotId(lastSnapshotId, snapshotId,
+            scanContext.maxSnapshotCountPerMonitorInterval());
         newScanContext = scanContext.copyWithAppendsBetween(lastSnapshotId, 
snapshotId);
       }
 
+      LOG.debug("Start discovering splits from {}(exclusive) to 
{}(inclusive),", lastSnapshotId, snapshotId);

Review Comment:
   This is missing spaces between the snapshot IDs and the inclusive or 
exclusive clarification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org