danielcweeks commented on PR #4978: URL: https://github.com/apache/iceberg/pull/4978#issuecomment-1153004245
@findepi Iceberg doesn't currently annotate methods or parameters using `@NonNull` or `@NotNull` though, there are places where `@Nullable` is currently used. I would be favor of making this more explicit, but I would prefer to use either `javax.validation.constraints.NotNull` or `javax.annotation.Nonnull` as opposed to introducing dependencies on projects like `findbugs` or related IDE or framework based annotations. I think based on currently accepted usage, `javax.validation.constraints.NotNull` might be the best option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
